lkml.org 
[lkml]   [2012]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] watchdog: Quiet down the boot messages

* Dave Jones <davej@redhat.com> wrote:

> On Mon, Jun 11, 2012 at 04:04:10PM -0400, Don Zickus wrote:
> > A bunch of bugzillas have complained how noisy the nmi_watchdog is during
> > boot-up especially with its expected failure cases (like virt and bios
> > resource contention).
> >
> > This is my attempt to quiet them down and keep it less confusing for the end
> > user. What I did is print the message for cpu0 and save it for future
> > comparisons. If future cpus have an identical message as cpu0, then don't
> > print the redundant info. However, if a future cpu has a different message,
> > happily print that loudly.
>
> Would anyone object to compressing these lines too ?
>
> > ... version: 2
> > ... bit width: 40
> > ... generic registers: 2
> > ... value mask: 000000ffffffffff
> > ... max period: 000000007fffffff
> > ... fixed-purpose events: 3
> > ... event mask: 0000000700000003
>
> That's a lot of wasted space, that could just as easily take
> up two lines without losing readability.

Yeah, we can do that, this was early debug code.

I'd suggest compressing it further, to a single line, to
something like:

... ver: 2, regs: 2/3, bits: 40, masks: 0xffffffffff/0x700000003/0x7fffffff

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-06-13 10:41    [W:0.673 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site