lkml.org 
[lkml]   [2012]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 16/24] PTY: add tty_port
On Wed, Jun 13, 2012 at 05:29:05PM -0700, Greg KH wrote:
> On Tue, Jun 12, 2012 at 03:55:44PM -0700, Greg KH wrote:
> > On Mon, Jun 04, 2012 at 01:35:30PM +0200, Jiri Slaby wrote:
> > > This has *no* function in the PTY driver yet. However as the tty
> > > buffers will move to the tty_port structure, we will need tty_port for
> > > all TTYs in the system, PTY inclusive.
> > >
> > > For PTYs this is ensured by allocating 2 tty_port's in pty_install,
> > > i.e. where the tty->link is allocated. Both tty_port's are properly
> > > assigned to each end of the tty.
> > >
> > > Freeing is done at the same place where tty is freed, i.e. in
> > > tty->ops->cleanup.
> > >
> > > This means BTW that tty_port does not outlive TTY in PTY. This might
> > > be a subject to change in the future if we see some problems.
> > >
> > > Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> > > ---
> > > drivers/tty/pty.c | 25 +++++++++++++++++++++----
> > > 1 file changed, 21 insertions(+), 4 deletions(-)
> >
> > As the locking rework got removed from Linus's tree, this patch doesn't
> > apply, so I've stopped at this point in the series.
>
> Argh, this was my fault, sorry, let me try this again, I missed 14 and
> 15 for some reason...

Yup, that fixed it, ok, I've applied the rest now, let me know if I
messed anything up.

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-06-14 03:01    [W:0.059 / U:5.768 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site