Messages in this thread | | | Date | Wed, 13 Jun 2012 21:37:36 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH 1/3] i2c-piix4: eliminate piix4_smba global variable |
| |
On Wed, 13 Jun 2012 12:59:07 -0400, Andrew Armenia wrote: > Some chipsets have multiple sets of piix4-compatible SMBus registers. > Eliminating the global variable will allow these chipsets to be fully > supported. > > Return value from piix4_setup and piix4_sb800_setup now returns the smba > value detected. This is stored in a struct i2c_piix4_adapdata. Thus > the global variable is eliminated. > > Signed-off-by: Andrew Armenia <andrew@asquaredlabs.com> > --- > drivers/i2c/busses/i2c-piix4.c | 54 ++++++++++++++++++++++++++++------------ > 1 file changed, 38 insertions(+), 16 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c > index c14d48d..61a85c9 100644 > --- a/drivers/i2c/busses/i2c-piix4.c > +++ b/drivers/i2c/busses/i2c-piix4.c > (...) > -static void __devexit piix4_remove(struct pci_dev *dev) > +static void __devinit piix4_adap_remove(struct i2c_adapter *adap)
You mean __devexit here.
Other than this, looks good, applied, thanks.
-- Jean Delvare
| |