lkml.org 
[lkml]   [2012]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] Staging: keucr: scsiglue: fixed a do while coding style issue
    Date
    Added a do ... while (0) to a multi statement macro and reformatted a similar macro.

    Signed-off-by: William Blair <wdblair@bu.edu>
    ---
    drivers/staging/keucr/scsiglue.c | 11 ++++++++---
    1 files changed, 8 insertions(+), 3 deletions(-)

    diff --git a/drivers/staging/keucr/scsiglue.c b/drivers/staging/keucr/scsiglue.c
    index e1f3931..083b20e 100644
    --- a/drivers/staging/keucr/scsiglue.c
    +++ b/drivers/staging/keucr/scsiglue.c
    @@ -230,7 +230,10 @@ void usb_stor_report_bus_reset(struct us_data *us)
    /* we use this macro to help us write into the buffer */
    #undef SPRINTF
    #define SPRINTF(args...) \
    - do { if (pos < buffer+length) pos += sprintf(pos, ## args); } while (0)
    + do { \
    + if (pos < buffer+length) \
    + pos += sprintf(pos, ## args); \
    + } while (0)

    /*
    * proc_info()
    @@ -279,8 +282,10 @@ static int proc_info(struct Scsi_Host *host, char *buffer, char **start,
    pos += sprintf(pos, " Quirks:");

    #define US_FLAG(name, value) \
    - if (us->fflags & value)\
    - pos += sprintf(pos, " " #name);
    + do { \
    + if (us->fflags & value) \
    + pos += sprintf(pos, " " #name); \
    + } while (0);
    US_DO_ALL_FLAGS
    #undef US_FLAG

    --
    1.7.6


    \
     
     \ /
      Last update: 2012-06-13 08:01    [W:0.023 / U:31.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site