Messages in this thread | | | Date | Tue, 12 Jun 2012 14:36:44 -0700 | From | Greg KH <> | Subject | Re: [PATCH][RESEND] staging: speakup: fixed checkpatch and sparse warnings in selection.c |
| |
On Tue, Jun 12, 2012 at 02:44:11PM -0400, Chris Yungmann wrote: > Left in_atomic() call as more work is needed (see TODO note at top of function). > > Signed-off-by: Chris Yungmann <yungmann.chris@gmail.com> > --- > drivers/staging/speakup/selection.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/speakup/selection.c b/drivers/staging/speakup/selection.c > index fe1f405..006403d 100644 > --- a/drivers/staging/speakup/selection.c > +++ b/drivers/staging/speakup/selection.c > @@ -68,7 +68,7 @@ int speakup_set_selection(struct tty_struct *tty) > if (spk_sel_cons != vc_cons[fg_console].d) { > speakup_clear_selection(); > spk_sel_cons = vc_cons[fg_console].d; > - printk(KERN_WARNING > + pr_warn(KERN_WARNING
Nope, that will not work, sorry.
Actually, please use dev_warn() and friends instead of "raw" printk() calls is the better thing to do.
thanks,
greg k-h
| |