Messages in this thread | | | Date | Tue, 12 Jun 2012 09:44:45 -0700 | Subject | Re: [patch -next] irq_remap: silence a bogus pr_err() | From | Yinghai Lu <> |
| |
On Tue, Jun 12, 2012 at 9:26 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > There is an extra semicolon here so the pr_err() message is printed when > it is not intended. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c > index dafbad0..853902a 100644 > --- a/drivers/iommu/intel_irq_remapping.c > +++ b/drivers/iommu/intel_irq_remapping.c > @@ -938,7 +938,7 @@ intel_ioapic_set_affinity(struct irq_data *data, const struct cpumask *mask, > > err = apic->cpu_mask_to_apicid_and(cfg->domain, mask, &dest); > if (err) { > - if (assign_irq_vector(irq, cfg, data->affinity)); > + if (assign_irq_vector(irq, cfg, data->affinity)) > pr_err("Failed to recover vector for irq %d\n", irq); > return err; > }
introduced by:
commit ff164324123c0fe181d8de7dadcc7b3fbe25f2cf Author: Alexander Gordeev <agordeev@redhat.com> Date: Thu Jun 7 15:15:59 2012 +0200
x86/apic: Make cpu_mask_to_apicid() operations return error code -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |