Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/4] drivers/net/ethernet/sfc: Add efx_ prefix to set_bit_le() | Date | Tue, 12 Jun 2012 13:12:32 +0000 |
| |
On Tuesday 12 June 2012, Takuya Yoshikawa wrote: > > > > Hmm, any reason why we're not just using the existing non-atomic > > __set_bit_le() here? I think the helpers in sfc and tulip can > > just get removed if you use those. > > __set_bit_le() assumes long word alignment and does endian conversion > when needed.
Ah, I see.
> To be honest, I am a bit scared of changing drivers which I cannot test > on real hardware.
Ok, let's take your patches as they are then.
With the change to add clear_bit_le:
Acked-by: Arnd Bergmann <arnd@arndb.de>
| |