lkml.org 
[lkml]   [2012]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver
    On Tue, Jun 12, 2012 at 09:52:39AM +0100, Lee Jones wrote:
    > From: Lee Jones <lee.jones@linaro.org>
    > Date: Tue, 17 Apr 2012 16:04:13 +0100
    > Subject: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver
    >
    > Here we move the i2c-nomadik's default settings into the driver
    > rather than specifying them from platform code. At the time of
    > this writing we only have one user, the u8500. As new users are
    > added, it is expected that they will be Device Tree compliant.
    > If this is the case, we will look up their initialisation values
    > by compatible entry, then apply them forthwith.
    >
    > Cc: linux-i2c@vger.kernel.org
    > Acked-by: Linus Walleij <linus.walleij@linaro.org>
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Did you use checkpatch?

    ============

    Applying: i2c: Add Device Tree support to the Nomadik I2C driver
    CHECKPATCH
    WARNING: please, no space before tabs
    #37: FILE: drivers/i2c/busses/i2c-nomadik.c:909:
    +^I.tft = 1, ^I /* Tx FIFO threshold */$

    WARNING: please, no space before tabs
    #38: FILE: drivers/i2c/busses/i2c-nomadik.c:910:
    +^I.rft = 8, ^I /* Rx FIFO threshold */$

    WARNING: please, no space before tabs
    #40: FILE: drivers/i2c/busses/i2c-nomadik.c:912:
    +^I.timeout = 200, ^I /* Slave response timeout(ms) */$

    ERROR: code indent should use tabs where possible
    #56: FILE: drivers/i2c/busses/i2c-nomadik.c:927:
    + const struct of_device_id *of_id =$

    WARNING: please, no spaces at the start of a line
    #56: FILE: drivers/i2c/busses/i2c-nomadik.c:927:
    + const struct of_device_id *of_id =$

    ERROR: code indent should use tabs where possible
    #57: FILE: drivers/i2c/busses/i2c-nomadik.c:928:
    + of_match_device(nmk_gpio_match, &pdev->dev);$

    WARNING: please, no spaces at the start of a line
    #57: FILE: drivers/i2c/busses/i2c-nomadik.c:928:
    + of_match_device(nmk_gpio_match, &pdev->dev);$

    total: 2 errors, 5 warnings, 0 checks, 59 lines checked

    NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
    scripts/cleanfile

    Your patch has style problems, please review.

    ============

    Regards,

    Wolfram

    --
    Pengutronix e.K. | Wolfram Sang |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-06-12 11:42    [W:4.292 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site