lkml.org 
[lkml]   [2012]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: ipack: remove pr_fmt definition.
On Mon, Jun 11, 2012 at 09:40:04AM +0200, Samuel Iglesias Gonsálvez wrote:
> On Mon, 2012-06-11 at 10:27 +0300, Dan Carpenter wrote:
> > On Mon, Jun 11, 2012 at 10:25:00AM +0300, Dan Carpenter wrote:
> > > On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote:
> > > > As there is no pr_* function used here, pr_fmt is not needed.
> > > >
> > >
> > > Nah. What about if we decide to add some? Also there are actually
> > > a couple pr_err() calls in there already.
> >
> > Oops. Sorry my tree is old. We removed the two calls to pr_err().
>
> Same mistake here. In greg's staging-next the pr_err calls are not
> present so the patch is totally valid but in linus branch they are there
> (this is the reason of my error).
>
> So, this patch is valid, unless we want the pr_fmt definition for the
> future. However, I prefer to delete it.
>

Sure. I guess everything in staging/ipack/ uses dev_err() type
print statements and that includes more information than the the
pr_fmt() macro already.

Acked-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-06-11 11:02    [from the cache]
©2003-2011 Jasper Spaans