Messages in this thread | | | Date | Mon, 11 Jun 2012 10:33:45 -0700 | Subject | Re: [PATCH UPDATED] block: In blk_execute_rq_nowait, init rq->end_io before checking for dead queue. | From | Muthu Kumar <> |
| |
On Sun, Jun 10, 2012 at 10:40 AM, Bart Van Assche <bvanassche@acm.org> wrote: > On 06/09/12 23:57, Muthu Kumar wrote: > >> Locking change is the one you posted already (the link above). Anyway, >> I have the attached patch *including* the locking change. Original >> mail has attachment without locking change. Please use whatever you >> need. > > > While we are at it ... the rq->rq_disk and rq->end_io assignments can be > performed safely before the spinlock is taken, isn't it ? >
Yes.. that spinlock is to protect the q.
> Bart.
| |