lkml.org 
[lkml]   [2012]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/6] sh: fix compiler warning by properly inlining flat_set_persistent()
    From
    On Mon, Jun 11, 2012 at 12:50 AM, Paul Mundt <lethal@linux-sh.org> wrote:
    > On Sun, Jun 10, 2012 at 06:33:10PM -0300, Ezequiel Garcia wrote:
    >> On Sat, Jun 9, 2012 at 6:14 AM, Paul Mundt <lethal@linux-sh.org> wrote:
    >> > On Sat, Jun 09, 2012 at 05:13:26AM -0300, Ezequiel Garcia wrote:
    >> >> This patch removes the following warning:
    >> >> fs/binfmt_flat.c:752: warning: unused variable ???persistent???
    >> >> There is neither change in functionality, nor extra code generated.
    >> >>
    >> >> Cc: Paul Mundt <lethal@linux-sh.org>
    >> >> Cc: <linux-sh@vger.kernel.org>
    >> >> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
    >> >
    >> > That's what the cast was for, with what gcc version did that stop
    >> > working?
    >>
    >> I just realized that I should send a v2 (not the whole series just this one)
    >> correcting the commit message, since there wasn't a warning to fix
    >> in first place.
    >>
    >> I'll do this soon.
    >
    > If there's no warning then the point of the patch eludes me. There's
    > nothing wrong with consistency, but attempting to fix that which isn't
    > broken in the name of consistency borders a bit too closely on pointless
    > busy work for my liking.

    If you feel like that, then it's perfectly fine with me.
    As I already told you, I was going to propagate your magical define to
    the rest of arches,
    but the inline looked a bit more readable.

    Sorry for the noise and thanks for your time.

    Regards,
    Ezequiel.


    \
     
     \ /
      Last update: 2012-06-11 19:21    [W:0.040 / U:1.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site