| From | Miklos Szeredi <> | Subject | Re: [PATCH 00/21] vfs: atomic open v6 (part 2) | Date | Mon, 11 Jun 2012 18:33:20 +0200 |
| |
I don't like this:
make ->atomic_open() return int
Change of calling conventions: old new NULL 1 file 0 ERR_PTR(-ve) -ve
Caller *knows* that struct file *; no need to return it.
Yes, ordinary filesystems the caller knows the 'struct file *' but for overlayfs (and stacking in general) wants to be able to return a file obtained by opening the file on another filesystem.
Thanks, Miklos
|