lkml.org 
[lkml]   [2012]   [Jun]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] clock: max77686: Add driver for Maxim 77686 32KHz crystal oscillator
On Mon, Jun 11, 2012 at 04:35:31PM +0900, Jonghwa Lee wrote:

> +static int max77686_clk_enable(struct clk_hw *hw)

> +static void max77686_clk_disable(struct clk_hw *hw)

These need to be prepare() and unprepare() since these operations are
atomic.

> +{
> + struct max77686_clk *max77686 = NULL;

The assignments here are redundant since you assign to the variable
immadiately.

> + for ( i = 0; i < MAX77686_CLKS_NUM; i++) {

Coding style with ( i.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-06-11 12:42    [W:0.070 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site