lkml.org 
[lkml]   [2012]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/27] m32r: Fix horrible logic in smp_prepare_cpus()
    Date
    In smp_prepare_cpus(), after max_cpus are booted, instead of breaking
    from the loop, the 'continue' statement is used which results in unnecessarily
    wasting time by looping NR_CPUS times!

    Many things around this could be pulled into generic code in the future, but
    for now, fix this particular piece of code locally (because I am unable to
    convince myself to ignore it even temporarily, given that it is such a gem!).

    And also rewrite the 'if' statement in a more natural way.

    Cc: Hirokazu Takata <takata@linux-m32r.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-m32r@ml.linux-m32r.org
    Cc: linux-m32r-ja@ml.linux-m32r.org
    Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
    ---
    arch/m32r/kernel/smpboot.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)
    diff --git a/arch/m32r/kernel/smpboot.c b/arch/m32r/kernel/smpboot.c
    index a2cfc0a..6ddc51a 100644
    --- a/arch/m32r/kernel/smpboot.c
    +++ b/arch/m32r/kernel/smpboot.c
    @@ -209,8 +209,8 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
    if (!physid_isset(phys_id, phys_cpu_present_map))
    continue;

    - if (max_cpus <= cpucount + 1)
    - continue;
    + if (cpucount + 1 >= max_cpus)
    + break;

    do_boot_cpu(phys_id);



    \
     
     \ /
      Last update: 2012-06-01 12:01    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean