lkml.org 
[lkml]   [2012]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add new NRP power meter USB device driver
On Fri, 1 Jun 2012 16:16:36 +0200
Oliver Neukum <oneukum@suse.de> wrote:

> Am Donnerstag, 31. Mai 2012, 11:21:40 schrieb Stefani Seibold:
> > On Thu, 2012-05-31 at 10:20 +0200, Oliver Neukum wrote:
> >
> > > > >
> > > > > > + if (arg) {
> > > > > > + ret = wait_event_interruptible_timeout(
> > > > > > + dev->out_running.wait,
> > > > > > + list_empty(&dev->out_running.urb_list),
> > > > > > + msecs_to_jiffies(arg));
> > > > > > + if (!ret)
> > > > > > + return -ETIMEDOUT;
> > > > > > + if (ret < 0)
> > > > > > + return ret;
> > > > > > + return 0;
> > > > > > + } else {
> > > > > > + return wait_event_interruptible(
> > > > > > + dev->out_running.wait,
> > > > > > + list_empty(&dev->out_running.urb_list));
> > > > > > + }
> > > > > > + break;
> > > > >
> > > > > This is very ugly. If you need fsync(), then implement it.
> > > > >
> > > >
> > > > fsync() did not meat the requirements, since i need in some case a
> > > > timeout for the device. poll() will also not help, since it signals only
> > > > that there is space to write.
> > >
> > > Well, then implement fsync() with interruptible sleep and use a timer
> > > in user space.
> > >
> >
> > But this will not solve the problem of older software which is still
> > depending on this ioctl.
>
> Yes. I guess it might be included in a depreated form. However
> a sane alternative must be provided.

It's a new kernel driver it's not bound to any existing API and we
regularly enforce a sane API on drivers being merged so I think the
legacy stuff is just "tough" - the out of tree driver will work fine with
any legacy code.

Alan


\
 
 \ /
  Last update: 2012-06-01 17:01    [W:0.114 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site