lkml.org 
[lkml]   [2012]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[PATCH 0/5] Some vmevent fixes...
    On Tue, May 08, 2012 at 10:36:31AM +0300, Pekka Enberg wrote:
    [...]
    > > 2) VMEVENT_ATTR_STATE_ONE_SHOT is misleading name. That is effect as
    > > edge trigger shot. not only once.
    >
    > Would VMEVENT_ATTR_STATE_EDGE_TRIGGER be a better name?
    [...]
    > > 4) Currently, vmstat have per-cpu batch and vmstat updating makes 3
    > > second delay at maximum.
    > >  This is fine for usual case because almost userland watcher only
    > > read /proc/vmstat per second.
    > >  But, for vmevent_fd() case, 3 seconds may be unacceptable delay. At
    > > worst, 128 batch x 4096
    > >  x 4k pagesize = 2G bytes inaccurate is there.
    >
    > That's pretty awful. Anton, Leonid, comments?
    [...]
    > > 5) __VMEVENT_ATTR_STATE_VALUE_WAS_LT should be removed from userland
    > > exporting files.
    > >  When exporing kenrel internal, always silly gus used them and made unhappy.
    >
    > Agreed. Anton, care to cook up a patch to do that?

    KOSAKI-San, Pekka,

    Much thanks for your reviews!

    These three issues should be fixed by the following patches. One mm/
    change is needed outside of vmevent...

    And I'm looking into other issues you pointed out...

    Thanks!

    ---
    include/linux/vmevent.h | 10 +++----
    include/linux/vmstat.h | 2 ++
    mm/vmevent.c | 66 +++++++++++++++++++++++++++++------------------
    mm/vmstat.c | 22 +++++++++++++++-
    4 files changed, 68 insertions(+), 32 deletions(-)

    --
    Anton Vorontsov
    Email: cbouatmailru@gmail.com
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-06-01 14:41    [W:0.023 / U:1.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site