lkml.org 
[lkml]   [2012]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/23] x86, realmode: Move reboot_32.S to unified realmode code
Il 08/05/2012 20:22, Jarkko Sakkinen ha scritto:
> + xorl %ecx, %ecx
> + movl %cr0, %edx
> + andl $0x00000011, %edx
> + orl $0x60000000, %edx
> + movl %edx, %cr0
> + movl %ecx, %cr3
> + movl %cr0, %edx
> + andl $0x60000000, %edx /* If no cache bits -> no wbinvd */

Shouldn't this be a testl?

> + jz 2f
> + wbinvd
> +2:
> + andb $0x10, %dl

... because otherwise this is really a mov $0, %edx and it sounds wrong.
It doesn't really matter, nobody really uses bit 4 of CR0 anymore,
still would be nice to fix it.

> + movl %edx, %cr0

Paolo


\
 
 \ /
  Last update: 2012-05-09 09:41    [from the cache]
©2003-2011 Jasper Spaans