| Date | Wed, 09 May 2012 06:51:20 +0100 | From | Ben Hutchings <> | Subject | [ 051/167] nfsd: fix endianness breakage in TEST_STATEID handling |
| |
3.2-stable review patch. If anyone has any objections, please let me know.
------------------
From: Al Viro <viro@zeniv.linux.org.uk>
From: Al Viro <viro@zeniv.linux.org.uk>
commit 02f5fde5df0ea930e70f93763dd48beff182b208 upstream.
->ts_id_status gets nfs errno, i.e. it's already big-endian; no need to apply htonl() to it. Broken by commit 174568 (NFSD: Added TEST_STATEID operation) last year...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Cc: "J. Bruce Fields" <bfields@fieldses.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- fs/nfsd/nfs4xdr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -3410,7 +3410,7 @@ nfsd4_encode_test_stateid(struct nfsd4_c nfsd4_decode_stateid(argp, &si); valid = nfs4_validate_stateid(cl, &si); RESERVE_SPACE(4); - *p++ = htonl(valid); + *p++ = valid; resp->p = p; } nfs4_unlock_state();
|