Messages in this thread | | | Date | Wed, 09 May 2012 22:37:24 +0200 | From | Markus Franke <> | Subject | Re: [PATCH] w1: Add 1-wire slave device driver for DS28E04-100 |
| |
Dear Evgeniy,
I have reworked the patch and now I am not getting any checkpatch warnings or errors anymore.
How about the binary sysfs files? If I understand correctly I would add a documentation file under Documentation/w1/slaves which documents both sysfs files (eeprom & pio).
@Greg: Could you live with those driver specific binary sysfs files?
Best regards, Markus Franke
Am 03.05.2012 20:00, schrieb Evgeniy Polyakov:
> On Wed, May 02, 2012 at 01:21:34PM -0700, Greg KH (greg@kroah.com) wrote: >>> Well, I just stuck to the way things are done in already existing >>> drivers e.g. drivers/w1/slaves/w1_ds2433.c >> >> Really? Ick, where are those files documented? > > I'm kinda lost here. > > To clarify things a bit - w1 allows to create 'private' sysfs files for > special functionality which exists only in given driver - like > enable/disable checksum and so on. It has to be documented and must > follow common kernel codying standards of course. >
| |