On 05/08/2012 11:18 PM, H. Peter Anvin wrote:

> On 05/08/2012 07:03 AM, Alex Shi wrote:
>> 
>> -	if (!cpu_has_invlpg || vma->vm_flags & VM_HUGETLB) {
>> +	if (!cpu_has_invlpg || vma->vm_flags & VM_HUGETLB
>> +				|| !tlb_flushall_factor) {
> 
> OK nevermind on the division by zero, but this yet another test being
> performed.
> 
> If nothing else you could fold these tests and make tlb_flushall_factor
> zero if !cpu_has_invlpg.


Yes, should be.

> 
> 	-hpa
>