lkml.org 
[lkml]   [2012]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] coredump: flush the fpu exit state for proper multi-threaded core dump
    Date
    Nalluru reported hitting the BUG_ON(__thread_has_fpu(tsk)) in
    arch/x86/kernel/xsave.c:__sanitize_i387_state() during the coredump
    of a multi-threaded application.

    A look at the exit seqeuence shows that other threads can still be on the
    runqueue potentially at the below shown exit_mm() code snippet:

    if (atomic_dec_and_test(&core_state->nr_threads))
    complete(&core_state->startup);

    ===> other threads can still be active here, but we notify the thread
    ===> dumping core to wakeup from the coredump_wait() after the last thread
    ===> joins this point. Core dumping thread will continue dumping
    ===> all the threads state to the core file.

    for (;;) {
    set_task_state(tsk, TASK_UNINTERRUPTIBLE);
    if (!self.task) /* see coredump_finish() */
    break;
    schedule();
    }

    As some of those threads are on the runqueue and didn't call schedule() yet,
    their fpu state is still active in the live registers and the thread
    proceeding with the coredump will hit the above mentioned BUG_ON while
    trying to dump other threads fpustate to the coredump file.

    BUG_ON() in arch/x86/kernel/xsave.c:__sanitize_i387_state() is
    in the code paths for processors supporting xsaveopt. With or without
    xsaveopt, multi-threaded coredump is broken and maynot contain
    the correct fpustate at the time of exit.

    If the coredump is in progress, explicitly flush the fpu state by calling
    prepare_to_copy().

    Reported-by: Suresh Nalluru <suresh@aristanetworks.com>
    Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
    ---
    kernel/exit.c | 5 +++++
    1 files changed, 5 insertions(+), 0 deletions(-)

    diff --git a/kernel/exit.c b/kernel/exit.c
    index d8bd3b42..dc90d63 100644
    --- a/kernel/exit.c
    +++ b/kernel/exit.c
    @@ -656,6 +656,11 @@ static void exit_mm(struct task_struct * tsk)
    struct core_thread self;
    up_read(&mm->mmap_sem);

    + /*
    + * Flush the live extended register state to memory.
    + */
    + prepare_to_copy(tsk);
    +
    self.task = tsk;
    self.next = xchg(&core_state->dumper.next, &self);
    /*
    --
    1.7.6.5


    \
     
     \ /
      Last update: 2012-05-09 01:41    [W:0.023 / U:64.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site