Messages in this thread |  | | Date | Sun, 6 May 2012 12:03:14 +0200 | | From | Borislav Petkov <> | | Subject | Re: [PATCH] x86: kernel/microcode_core.c simple_strtoul cleanup |
| |
On Sat, May 05, 2012 at 09:37:39AM -0600, Shuah Khan wrote: > Change reload_for_cpu() in kernel/microcode_core.c to call kstrtoul() > instead of calling obsoleted simple_strtoul(). > > From 8df8b8f87a8e462faa7b4c2b4682b23df5afa4bd Mon Sep 17 00:00:00 2001 > From: Shuah Khan <shuahkhan@gmail.com> > Date: Fri, 4 May 2012 14:12:11 -0600 > Subject: [PATCH] x86: kernel/microcode_core.c simple_strtoul cleanup > > > Signed-off-by: Shuah Khan <shuahkhan@gmail.com> > --- > arch/x86/kernel/microcode_core.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c > index c9bda6d..fbdfc69 100644 > --- a/arch/x86/kernel/microcode_core.c > +++ b/arch/x86/kernel/microcode_core.c > @@ -299,12 +299,11 @@ static ssize_t reload_store(struct device *dev, > { > unsigned long val; > int cpu = dev->id; > - int ret = 0; > - char *end; > + ssize_t ret = 0; > > - val = simple_strtoul(buf, &end, 0); > - if (end == buf) > - return -EINVAL; > + ret = kstrtoul(buf, 0, &val); > + if (ret) > + return ret; > > if (val == 1) { > get_online_cpus(); > -- > 1.7.9.5
Patch looks correct but your patch format looks all flipped: first you have the commit message and then the mail headers you get from git format-patch, what happened? IOW, it should be the other way around.
Go look at other messages on lkml starting with "tip-bot" in the From: for a proper patch formatting pls.
Thanks.
-- Regards/Gruss, Boris.
|  |