Messages in this thread | | | Date | Fri, 4 May 2012 19:36:22 -0700 | From | Anton Vorontsov <> | Subject | Re: [PATCH] max17042_battery: fix driver exit function |
| |
Hello Ramakrishna,
On Tue, Apr 10, 2012 at 05:20:33AM +0000, Pallala, Ramakrishna wrote: [...] > > power_supply_unregister(&chip->battery); > > + if (client->irq) > > + free_irq(client->irq, chip); > > + i2c_set_clientdata(client, NULL); > > + > > return 0; > > } > > I have not received any comments for this patch. > Can I assume that this patch is in your merge queue?
Applied, but I removed i2c_set_clientdata(client, NULL) line in this patch. It is not be required nowadays, I2C core does it by itself.
Plus, I changed the order of the calls: we should free irq first, then unregister the power supply (btw, you might want to fix probe function as well: it should request irq only after power supply object is fully usable).
Thanks!
-- Anton Vorontsov Email: cbouatmailru@gmail.com
| |