lkml.org 
[lkml]   [2012]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/4] kbuild: link of vmlinux moved to a script
    Hi Sam,

    Thanks a lot for this work and sorry for the delay.

    Dne 28.4.2012 22:59, Sam Ravnborg napsal(a):
    > +kallsymso=""
    > +kallsyms_vmlinux=""
    > +if [ -n "${CONFIG_KALLSYMS}" ]; then
    > +
    [...]
    > +
    > + kallsymso=.tmp_kallsyms2.o
    > + kallsyms_vmlinux=.tmp_vmlinux2
    > +
    > + # step 1
    > + vmlinux_link "" .tmp_vmlinux1
    > + kallsyms .tmp_vmlinux1 .tmp_kallsyms1.o
    > +
    > + # step 2
    > + vmlinux_link .tmp_kallsyms1.o .tmp_vmlinux2
    > + kallsyms .tmp_vmlinux2 .tmp_kallsyms2.o
    > +
    > + # step 2a
    > + if [ -n "${KALLSYMS_EXTRA_PASS}" ]; then
    > + kallsymso=.tmp_kallsyms3.o
    > + kallsyms_vmlinux=.tmp_vmlinux2

    This should read ".tmp_vmlinux3". Also, how about storing these two
    variables in the kallsyms() function instead? That way, you have the
    assignment in one place only and this block becomes a little simpler.

    This was the only error I spotted, it looks fine otherwise. Please
    resubmit with the above typo fixed (whether or not you move the variable
    assignments I leave up to you) and I'll add it to linux-next.

    Thanks,
    Michal


    \
     
     \ /
      Last update: 2012-05-05 01:41    [W:0.022 / U:95.392 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site