Messages in this thread Patch in this message | | | From | Eric Nelson <> | Subject | [PATCH V2] checkpatch: add check for whitespace before semicolon at end-of-line | Date | Fri, 4 May 2012 08:59:46 -0700 |
| |
Requires --strict option during invocation: ~/linux$ scripts/checkpatch --strict foo.patch
This tests for a bad habits of mine like this:
return 0 ;
Note that it does allow a special case of a bare semicolon for empty loops:
while (foo()) ;
--- V2 adds the special case and requirement for --strict based on recommendations of Joe Perches.
scripts/checkpatch.pl | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a3b9782..e711122 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3227,6 +3227,12 @@ sub process { "Statements terminations use 1 semicolon\n" . $herecurr); } +# check for whitespace before semicolon - not allowed at end-of-line + if ($line =~ /\S+\s+;$/) { + CHK("SPACING", + "Whitespace before semicolon\n" . $herecurr); + } + # check for gcc specific __FUNCTION__ if ($line =~ /__FUNCTION__/) { WARN("USE_FUNC", -- 1.7.9
| |