lkml.org 
[lkml]   [2012]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] ARM: tegra: Add Tegra Memory Controller(MC) driver
    On Thu, 3 May 2012 22:13:23 +0200
    Olof Johansson <olof@lixom.net> wrote:

    > Hi,
    >
    > On Thu, May 3, 2012 at 11:39 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
    > > On 05/03/2012 10:51 AM, Hiroshi DOYU wrote:
    > >> Tegra Memory Controller(MC) driver for Tegra20/30.
    > >> Added to support MC General interrupts, mainly for IOMMU.
    > >
    > >> The location of a file may not be suitable because of xxx_driver under arch/arm/mach-*.
    > >> ---
    > >> diff --git a/arch/arm/mach-tegra/Makefile b/arch/arm/mach-tegra/Makefile
    > >
    > > Russell, Olof, Arnd,
    > >
    > > Where should this driver be placed? It's a completely Tegra-specific
    > > module, and I don't believe there's any drivers/ directory or other
    > > subsystem that's appropriate to house it right now. Should we go ahead
    > > and create a drivers/arm/ for this? Perhaps drivers/misc/?
    >
    > TI just added their memory driver in drivers/memory, and it was merged
    > through Greg K-H's driver tree. That would be a good location for this
    > one as well.
    >
    > > Honestly, to me it seems best to keep purely platform-specific drivers
    > > like this in arch/arm/mach-tegra, since that's the most closely
    > > Tegra-related directory.
    >
    > Since tegra has a custom memory controller it's not as obvious that it
    > needs to go in a shared location, indeed. But it's easier to use the
    > same practices across platforms, and if there are other vendors that
    > end up sharing IP blocks for memory down the road, having them in a
    > common location makes sense.

    I think that the above TI's patch is:

    Add TI EMIF SDRAM controller driver
    http://lwn.net/Articles/494922/

    I'm moving this Tegra MC driver under drivers/memory, "tegra{20,30}-mc.c".


    \
     
     \ /
      Last update: 2012-05-04 07:41    [W:0.029 / U:60.744 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site