Messages in this thread | | | Subject | Re: [PATCH 3/5] x86: Reset the debug_stack update counter | From | Steven Rostedt <> | Date | Thu, 31 May 2012 15:26:33 -0400 |
| |
On Thu, 2012-05-31 at 12:19 -0700, H. Peter Anvin wrote: > On 05/30/2012 06:28 PM, Steven Rostedt wrote: > >> > > diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c index > > 9087527..c1fffc5 100644 --- a/arch/x86/kernel/nmi.c +++ > > b/arch/x86/kernel/nmi.c @@ -450,8 +450,10 @@ static inline void > > nmi_nesting_preprocess(struct pt_regs *regs) > > > > static inline void nmi_nesting_postprocess(void) { - if > > (unlikely(__get_cpu_var(update_debug_stack))) + if > > (unlikely(__get_cpu_var(update_debug_stack))) { > > debug_stack_reset(); + __get_cpu_var(update_debug_stack) = 0; + } > > } #endif > > > > Please don't use __get_cpu_var(); it causes a pointer to be manifest, > which is free or almost free on most architectures but quite expensive > on x86. > > Instead use this_cpu_read()/this_cpu_write().
OK, will change.
Thanks!
-- Steve
| |