Messages in this thread | | | Subject | Re: [PATCH 1/5] ftrace: Synchronize variable setting with breakpoints | From | Peter Zijlstra <> | Date | Thu, 31 May 2012 19:44:43 +0200 |
| |
On Thu, 2012-05-31 at 19:40 +0200, Peter Zijlstra wrote: > On Thu, 2012-05-31 at 10:08 -0400, Steven Rostedt wrote: > > > Also, why does this stuff live in ftrace? I always thought you were > > > going to replace text_poke() so everybody that uses cross-modifying code > > > could profit? > > > > I discussed this with Masami at Collaboration Summit. The two are > > similar but also very different. But we want to start merging the two > > together where it makes sense. > > Argh,. I so disagree. You're doing it backwards. > > First you merge whatever is there, regardless of who came first.
The thing is, that's useful even if the new stuff never works. Having two code-bases doing cross-modifying code in different ways just doesn't sound right. That stuff is tricky enough as it is.
| |