lkml.org 
[lkml]   [2012]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [patch] BFS 420: a tiny step forward
    From
    On Thu, May 31, 2012 at 7:15 PM, Hillf Danton <dhillf@gmail.com> wrote:
    > On Thu, May 31, 2012 at 3:12 PM, Emmanuel Benisty <benisty.e@gmail.com> wrote:
    >>
    >> This is what happens with Greg's 3.3.7 + Con's bfs-420 + your
    >> bfs-420-421 patches, any idea?
    >>
    >>  CC      kernel/sched/bfs.o
    >> kernel/sched/bfs.c: In function 'try_preempt':
    >> kernel/sched/bfs.c:1450:2: error: incompatible type for argument 2 of
    >> 'cpumask_next_and'
    >> include/linux/cpumask.h:192:5: note: expected 'const struct cpumask *'
    >> but argument is of type 'cpumask_t'
    >> kernel/sched/bfs.c:1450:2: error: incompatible type for argument 3 of
    >> 'cpumask_next_and'
    >> include/linux/cpumask.h:192:5: note: expected 'const struct cpumask *'
    >> but argument is of type 'cpumask_t'
    >> kernel/sched/bfs.c:1450:2: warning: left-hand operand of comma
    >> expression has no effect
    >> make[2]: *** [kernel/sched/bfs.o] Error 1
    >> make[1]: *** [kernel/sched] Error 2
    >> make: *** [kernel] Error 2
    >>
    >
    > My bad, lets try the follwoing fix /hd
    >
    >
    > --- a/kernel/sched/bfs.c        Wed May 30 21:04:10 2012
    > +++ b/kernel/sched/bfs.c        Thu May 31 20:05:44 2012
    > @@ -1447,7 +1447,7 @@ static void try_preempt(struct task_stru
    >        highest_prio = p->prio;
    >        latest_deadline = p->deadline;
    >
    > -       for_each_cpu_and(cpu, cpu_online_map, p->cpus_allowed) {
    > +       for_each_cpu_and(cpu, cpu_online_mask, tsk_cpus_allowed(p)) {
    >                struct rq *rq;
    >                int rq_prio;
    >
    > --

    Thanks a lot Hillf, it builds fine now but it won't boot. Some crappy
    mobile phone picture here:
    http://ompldr.org/vZTE1eQ/IMG_20120531_200543.jpg
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-31 15:41    [W:0.031 / U:2.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site