lkml.org 
[lkml]   [2012]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/22] regulator: Change ab8500 match names to reflect Device Tree
    On 31/05/12 00:41, Mark Brown wrote:
    > On Wed, May 30, 2012 at 11:22:33PM +0800, Lee Jones wrote:
    >> On 30/05/12 23:11, Mark Brown wrote:
    >
    >>>> vin-supply =<&db8500_vape_reg>;
    >>>> vmmc-supply =<&ab8500_ldo_aux2_reg>;
    >
    >>> Oh, oops. This is going to be fun when someone puts down two of the
    >>> same PMIC on a system...
    >
    >> What does that mean sorry?
    >
    > Lots of regulators are using this mechanism for identifying child nodes.
    > If the node name is also used as a handle by other things to reference
    > the regulator then if you have two PMICs of the same type DTC isn't
    > going to be able to figure out which node you mean.

    I haven't looked at the code yet, so I don't know the answer to this
    question, but; aren't they protected by the compatible string? If not, I
    think they should be. We shouldn't be parsing other platform's Device Trees.

    --
    Lee Jones
    Linaro ST-Ericsson Landing Team Lead
    M: +44 77 88 633 515
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-31 03:21    [W:0.027 / U:0.328 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site