Messages in this thread | | | Date | Wed, 30 May 2012 23:01:06 +0800 | From | Lee Jones <> | Subject | Re: [PATCH 08/22] regulator: Change ab8500 match names to reflect Device Tree |
| |
On 30/05/12 20:15, Mark Brown wrote: > On Wed, May 30, 2012 at 07:40:49PM +0800, Lee Jones wrote: >> On May 30, 2012 6:03 PM, "Mark Brown"<broonie@opensource.wolfsonmicro.com> > >>> If we are changing the names then not including the ab8500 bit would >>> seem more idiomatic - we've already worked out which chip this is by the >>> time we're looking here. > >> No, Linus had the wrong end of the stick. I've just spoken to him in person. > >> Those are not the names of the regulators. They're the names of the Device >> Tree nodes. The regulator names shall remain the same. > > Fair enough. My point about the ab8500_ bit still stands though.
It's a Device Tree thing. I do it so we can easily see which regulator is driving which device(s).
I personally think:
vin-supply = <&db8500_vape_reg>; vmmc-supply = <&ab8500_ldo_aux2_reg>;
Tells us so much more and is simpler to decrypt at a glance than something like:
vin-supply = <&vape_reg>; vmmc-supply = <&ldo_aux2_reg>;
-- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |