Messages in this thread | | | Subject | Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay | From | Benjamin Herrenschmidt <> | Date | Thu, 03 May 2012 18:09:21 +1000 |
| |
On Thu, 2012-05-03 at 14:59 +0800, Wang Sheng-Hui wrote: > On 2012年05月03日 14:33, Wang Sheng-Hui wrote: > > if (unlikely(irq_happened != PACA_IRQ_HARD_DIS)) > >> __hard_irq_disable(); > > I have commented out the 2 lines.
No, Only comment the test, you must absolutely leave the __hard_irq_disable() call ! That's the whole point of the test, make sure we unconditionally disable to see if that fixes the problem, in which case that will tell us that we somewhere accidentally leave irq_happened set to 0x01 while irqs are hard enabled.
Cheers, Ben.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |