lkml.org 
[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: staging/rtl8712: unhandled default case in SwLedOn function.
    > This should do:
    >
    > Index: staging/drivers/staging/rtl8712/rtl8712_led.c
    > ===================================================================
    > --- staging.orig/drivers/staging/rtl8712/rtl8712_led.c
    > +++ staging/drivers/staging/rtl8712/rtl8712_led.c
    > @@ -137,7 +137,8 @@ static void SwLedOn(struct _adapter *pad
    > r8712_write8(padapter, LEDCFG, LedCfg&0x0f);
    > break;
    > default:
    > - break;
    > + WARN_ONCE(1, "Default branch taken in %s\n", __func__);
    > + return;
    > }
    > pLed->bLedOn = true;
    > }
    >

    Don't just reflexively add extra debug code.

    In this case pLed->LedPin is either LED_PIN_LED0 or LED_PIN_LED1.
    The LED_PIN_GPIO0 and default cases are never used. Even if it were
    I think we would want to set pLed->bLedOn = true in the default
    case.

    The code is ugly as pants, but it works fine as is.

    regards,
    dan carpenter



    \
     
     \ /
      Last update: 2012-05-03 09:41    [W:0.023 / U:177.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site