lkml.org 
[lkml]   [2012]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3] tilegx network driver: initial support
    From
    From: Chris Metcalf <cmetcalf@tilera.com>
    Date: Mon, 17 Sep 2001 00:00:00 -0400

    > +/* #define USE_SIM_PRINTF */
    > +
    > +#ifdef USE_SIM_PRINTF
    > +
    > +static __attribute__((unused, format (printf, 1, 2))) void
    > +sim_printf(const char *format, ...)
    ...
    > +/* HACK: Allow use of "sim_printf()" instead of "printk()". */
    > +#define printk sim_printf
    > +
    > +#endif

    This doesn't belong in a driver.

    You want a debugging console driver that uses that special SIM output
    facility instead.

    Therefore, please remove this sim_printf stuff completely.


    \
     
     \ /
      Last update: 2012-05-03 08:21    [W:4.430 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site