lkml.org 
[lkml]   [2012]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH V2] MMC: core: cap MMC card timeouts at 2 seconds.
    From
    On 29 May 2012 03:32, Ben Hutchings <ben@decadent.org.uk> wrote:
    > On Mon, 2012-05-28 at 18:31 +0100, Torne (Richard Coles) wrote:
    >> From: "Torne (Richard Coles)" <torne@google.com>
    >>
    >> MMC CSD info can specify very large, ridiculous timeouts, big enough to
    >> overflow timeout_ns on 32-bit machines. This can result in the card
    >> timing out on every operation because the wrapped timeout value is far
    >> too small.
    >>
    >> Fix the overflow by capping the result at 2 seconds.  Cards specifying
    >> longer timeouts are almost certainly insane, and host controllers
    >> generally cannot support timeouts that long in any case.
    >>
    >> 2 seconds should be plenty of time for any card to actually function;
    >> the timeout calculation code is already using 1 second as a "worst case"
    >> timeout for cards running in SPI mode.
    >
    > Needs a 'Signed-off-by'.

    Oops, sorry. I'm still getting used to the patch workflow. Will resend.

    --
    Torne (Richard Coles)
    torne@google.com
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-29 11:41    [W:0.024 / U:6.488 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site