Messages in this thread | | | Date | Mon, 28 May 2012 10:51:31 +0100 | From | Alan Cox <> | Subject | Re: [PATCH v4 02/13] libata: bind the Linux device tree to the ACPI device tree |
| |
> +static int is_pci_ata(struct device *dev) > +{ > + struct pci_dev *pdev; > + > + if (!is_pci_dev(dev)) > + return 0; > + > + pdev = to_pci_dev(dev); > + > + if ((pdev->class >> 8) != PCI_CLASS_STORAGE_SATA && > + (pdev->class >> 8) != PCI_CLASS_STORAGE_IDE) > + return 0;
This needs a better name. It doesn't check if a device is PCI ATA or anything of the sort, it checks if its probably a device in compatibility mode. A lot of controllers will in fact report RAID class or similar in native mode.
Alan
| |