lkml.org 
[lkml]   [2012]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Allow constructor name selection by architecture.
On Mon, May 28, 2012 at 07:33:37PM +0100, Vincent Sanders wrote:
> From: Vincent Sanders <vince@collabora.co.uk>
>
> The constructor symbol name is different between platforms. Allow this
> to be selected by configuration and set suitable default values.
>
> Signed-off-by: Vincent Sanders <vincent.sanders@collabora.co.uk>
> ---
> include/asm-generic/vmlinux.lds.h | 6 +++---
> init/Kconfig | 6 ++++++
> kernel/module.c | 2 +-
> 3 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 8aeadf6..fd34808 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -471,9 +471,9 @@
> }
>
> #ifdef CONFIG_CONSTRUCTORS
> -#define KERNEL_CTORS() . = ALIGN(8); \
> - VMLINUX_SYMBOL(__ctors_start) = .; \
> - *(.ctors) \
> +#define KERNEL_CTORS() . = ALIGN(8); \
> + VMLINUX_SYMBOL(__ctors_start) = .; \
> + *(CONFIG_CONSTRUCTORS_NAME) \
> VMLINUX_SYMBOL(__ctors_end) = .;

What is wrong with adding both "standard" names for ctors uncnditionally?
Like this:
> *(.ctors) \
> + *(.init_array) \


Sam


\
 
 \ /
  Last update: 2012-05-28 22:41    [W:0.084 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site