lkml.org 
[lkml]   [2012]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 084/117] cifs: fix revalidation test in cifs_llseek()
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 48a5730e5b71201e226ff06e245bf308feba5f10 upstream.

    This test is always true so it means we revalidate the length every
    time, which generates more network traffic. When it is SEEK_SET or
    SEEK_CUR, then we don't need to revalidate.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Steve French <sfrench@us.ibm.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/cifs/cifsfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
    index ca6a379..541ef81 100644
    --- a/fs/cifs/cifsfs.c
    +++ b/fs/cifs/cifsfs.c
    @@ -699,7 +699,7 @@ static loff_t cifs_llseek(struct file *file, loff_t offset, int origin)
    * origin == SEEK_END || SEEK_DATA || SEEK_HOLE => we must revalidate
    * the cached file length
    */
    - if (origin != SEEK_SET || origin != SEEK_CUR) {
    + if (origin != SEEK_SET && origin != SEEK_CUR) {
    int rc;
    struct inode *inode = file->f_path.dentry->d_inode;




    \
     
     \ /
      Last update: 2012-05-28 06:01    [W:0.045 / U:0.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site