Messages in this thread | | | Subject | Re: [PATCH] [staging] bcm: Fix codingstyle problems | From | Joe Perches <> | Date | Sun, 27 May 2012 19:38:54 -0700 |
| |
On Sun, 2012-05-27 at 22:30 -0400, Kevin McKinney wrote: > Hi Devendra, > > On Sun, May 27, 2012 at 4:54 PM, Devendra Naga <devendra.aaru@gmail.com> wrote: > > Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> > > --- > > drivers/staging/bcm/Debug.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > I understand this is a simple change, but please add a descriptive > change log to your patch for consistency.
Hello as well.
Devendra, sometimes the simpler change isn't the best change. Consider converting some of these macros into functions.
| |