Messages in this thread | | | Subject | Re: [PATCH] x86-64: use EFI to deal with platform wall clock | From | Matt Fleming <> | Date | Sat, 26 May 2012 11:26:48 +0100 |
| |
On Fri, 2012-05-25 at 16:20 +0100, Jan Beulich wrote: > Other than ix86, x86-64 on EFI so far didn't set the {g,s}et_wallclock > accessors to the EFI routines, thus incorrectly using raw RTC accesses > instead. > > Simply removing the #ifdef around the respective code isn't enough, > however: While so far early get-time calls were done in physical mode, > this doesn't work properly for x86-64, as virtual addresses would still > need to be set up for all runtime regions (which wasn't the case on the > system I have access to), so instead the patch moves the call to > efi_enter_virtual_mode() ahead (which in turn allows to drop all code > related to calling efi-get-time in physical mode). > > Additionally the earlier calling of efi_set_executable() requires the > CPA code to cope, i.e. during early boot it must be avoided to call > cpa_flush_array(), as the first thing this function does is a > BUG_ON(irqs_disabled()). > > Also make the two EFI functions in question here static - they're not > being referenced elsewhere. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > Cc: Matt Fleming <matt.fleming@intel.com> > Cc: Matthew Garrett <mjg@redhat.com> > > --- > (Note that due to the lack of hardware I wasn't able to test this on > 32-bit EFI - Matt offered to do so subsequently.)
Appears to work fine here on 32-bit.
| |