[lkml]   [2012]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[ 24/94] SELinux: if sel_make_bools errors dont leave inconsistent state
3.3-stable review patch.  If anyone has any objections, please let me know.


From: Eric Paris <>

commit 154c50ca4eb9ae472f50b6a481213e21ead4457d upstream.

We reset the bool names and values array to NULL, but do not reset the
number of entries in these arrays to 0. If we error out and then get back
into this function we will walk these NULL pointers based on the belief
that they are non-zero length.

Signed-off-by: Eric Paris <>
Signed-off-by: Greg Kroah-Hartman <>

security/selinux/selinuxfs.c | 1 +
1 file changed, 1 insertion(+)

--- a/security/selinux/selinuxfs.c
+++ b/security/selinux/selinuxfs.c
@@ -1232,6 +1232,7 @@ static int sel_make_bools(void)
+ bool_num = 0;
bool_pending_names = NULL;
bool_pending_values = NULL;

 \ /
  Last update: 2012-05-27 04:01    [W:0.374 / U:26.860 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site