Messages in this thread | | | Date | Sun, 27 May 2012 09:22:05 +0900 | From | Greg KH <> | Subject | Re: [ 13/54] net: In unregister_netdevice_notifier unregister the netdevices. |
| |
On Sat, May 26, 2012 at 08:18:14PM -0400, David Miller wrote: > From: Greg KH <gregkh@linuxfoundation.org> > Date: Sun, 27 May 2012 09:13:49 +0900 > > > On Mon, May 21, 2012 at 02:35:12PM -0300, Herton Ronaldo Krzesinski wrote: > >> On Fri, May 18, 2012 at 02:16:12PM -0700, Greg KH wrote: > >> > 3.0-stable review patch. If anyone has any objections, please let me know. > >> > > >> > ------------------ > >> > > >> > > >> > From: "Eric W. Biederman" <ebiederm@xmission.com> > >> > > >> > [ Upstream commit 7d3d43dab4e978d8d9ad1acf8af15c9b1c4b0f0f ] > >> > > >> > We already synthesize events in register_netdevice_notifier and synthesizing > >> > events in unregister_netdevice_notifier allows to us remove the need for > >> > special case cleanup code. > >> > > >> > This change should be safe as it adds no new cases for existing callers > >> > of unregiser_netdevice_notifier to handle. > >> > > >> > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> > >> > Signed-off-by: David S. Miller <davem@davemloft.net> > >> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > >> > >> Please also include these two commits in addition to this change, to > >> avoid a regression with pktgen: > >> commit c57b54684060c8aced64a5b78ff69ff289af97b9 > >> commit d4b1133558e0d417342d5d2c49e4c35b428ff20d > > > > I need an ack from the network maintainers for me to be able to accept > > this. > > These bugs only effect networking hackers doing low-level packet > spamming on their network using pktgen, who furthermore try to unload > the pktgen module. > > Low level network packet spamming using pktgen, and trying to unload > that module, adds up to an extremely small minority of users. > > Therefore these changes are not worth putting into -stable by any > measurement.
Ok, thanks, I'll not do this for 3.0-stable then, as no developer should really be using that kernel anymore :)
greg k-h
| |