lkml.org 
[lkml]   [2012]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 00/16] vfs: atomic open v4 (part 1)
    Date
    Miklos Szeredi <miklos@szeredi.hu> wrote:

    > > For instance, in lookup_open(), you call security_path_mknod() prior to
    > > calling vfs_create(), but you don't call it prior to calling atomic_open()
    > > or in, say, nfs_atomic_open().
    >
    > We call security_path_mknod() before ->atomic_open() in may_o_create().

    Okay.

    > > I'm also wondering if you're missing an audit_inode() call in the if
    > > (created) path after the retry_lookup label.
    >
    > There's no audit_inode() on the created dentry neither in the original
    > code nor in the modified code.
    >
    > But that may be a bug regardless, it's just independent of my changes.
    > At least AFAICS.

    Fair enough.

    David


    \
     
     \ /
      Last update: 2012-05-25 17:41    [W:0.029 / U:63.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site