lkml.org 
[lkml]   [2012]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: USB device PM oddity in 3.5
    udev is being a little too aggressive in enabling autosuspend. I've just 
    sent a patch upstream, but here it is:

    commit 35c62663b93adb6ab321ca1e6ac6f1ba580b37aa
    Author: Matthew Garrett <mjg@redhat.com>
    Date: Fri May 25 08:00:05 2012 -0400

    rules: Limit USB autosuspend on USB HID devices

    Some USB ports on external hubs may be reported as "fixed". We only want
    to auto-enable this on ports that are internal to the machine, so check
    the parent state as well.

    diff --git a/rules/42-usb-hid-pm.rules b/rules/42-usb-hid-pm.rules
    index d5d5897..fc44b94 100644
    --- a/rules/42-usb-hid-pm.rules
    +++ b/rules/42-usb-hid-pm.rules
    @@ -46,4 +46,10 @@ ACTION=="add", SUBSYSTEM=="usb", ATTRS{idVendor}=="04b3", ATTR{idProduct}=="4012
    ACTION=="add", SUBSYSTEM=="usb", ATTR{idVendor}=="14dd", ATTR{idProduct}="0002", TEST=="power/control", ATTR{power/control}="auto"

    # USB HID devices that are internal to the machine should also be safe to autosuspend
    +
    +ACTION=="add", SUBSYSTEM=="usb", SUBSYSTEMS=="usb", ATTRS{removable}=="removable", GOTO="usb_hid_pm_end"
    +ACTION=="add", SUBSYSTEM=="usb", SUBSYSTEMS=="usb", ATTRS{removable}=="unknown", GOTO="usb_hid_pm_end"
    +
    ACTION=="add", SUBSYSTEM=="usb", ATTR{bInterfaceClass}=="03", ATTRS{removable}=="fixed", TEST=="../power/control", ATTR{../power/control}="auto"
    +
    +LABEL="usb_add_pm_end"
    --
    Matthew Garrett | mjg59@srcf.ucam.org

    \
     
     \ /
      Last update: 2012-05-25 15:41    [W:0.049 / U:0.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site