lkml.org 
[lkml]   [2012]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/4 V2] livedump: Add notifier-call-chain into do_page_fault
Hi, Peter,

I agree that notifier isn't suitable for this purpose.

In the next version, I plan to replace this with a simple
callback as follows.

if (very_unlikely(under_live_dump))
...
In addition to this, since PF handler is a very hot path,
I will cover the condition with "#ifdef CONFIG_WRPROTECT".

Thank you.


On 2012/05/25 18:19, Peter Zijlstra wrote:
> On Fri, 2012-05-25 at 18:12 +0900, YOSHIDA Masanori wrote:
>>
>> This patch adds notifier-call-chain that is called in do_page_fault.
>> Livedump uses this to check if page fault is caused by livedump, and if so,
>> the fault is handled by livedump's handler function. Otherwise, it is
>> handled by the original page fault handler.
>
> No, please no notifiers..
>
>
>



\
 
 \ /
  Last update: 2012-05-25 14:41    [from the cache]
©2003-2011 Jasper Spaans