Messages in this thread | | | From | Andrew Lutomirski <> | Date | Wed, 23 May 2012 18:46:58 -0700 | Subject | Re: [PATCH v7 8/8] x86/tlb: just do tlb flush on one of siblings of SMT |
| |
On Wed, May 23, 2012 at 10:15 AM, Peter Zijlstra <peterz@infradead.org> wrote: > On Wed, 2012-05-23 at 19:09 +0200, Peter Zijlstra wrote: >> > There is no comment or anything else indicating that this is >> > suitable for dual-thread CPUs only - when there are more than >> > 2 threads per core, the intended effect won't be achieved. >> >> Why would that be? Won't higher thread count still share the same >> resources just more so? > > Ah, I see, you're saying his code is buggy for >2 threads. Agreed. >
An evil knob to statically choose which SMT sibling gets the interrupt would be nice. Then my compute-intensive thread could be (mostly) unaffected by the other thread on a different core that calls munmap frequently.
--Andy
| |