Messages in this thread | | | Subject | Re: [PATCH 1/1] checkpatch: don't fake typedefs with #define | From | Joe Perches <> | Date | Tue, 22 May 2012 20:25:09 -0700 |
| |
On Wed, 2012-05-23 at 12:50 +1000, Ryan Mallon wrote: [] > #define __videocard struct card_info > __attribute__((section(".videocards"))) > I'm guessing is because typedefs don't handle __attribute__.
Probably not and likely it shouldn't be either a define or a typedef.
It's just not frequently used enough.
Maybe it could be more like DEFINE_PCI_DEVICE_TABLE though that's not pretty either.
> We could test for lots of things in checkpatch, but it seems more > sensible to check for issues which are likely.
Maybe, but being comprehensive isn't necessarily bad either.
Look at __setup, all the <foo>_ops tests, the blackfin tests, etc. in checkpatch.
I don't care much one way or another.
Again, if Andrew or Andy wants to push it forward, it's fine by me.
cheers, Joe
| |