lkml.org 
[lkml]   [2012]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 2/2] regulator: Add support for MAX77686.
    Hi, again.
    On 2012년 05월 22일 14:57, yadi.brar01@gmail.com wrote:


    > +static __devinit int max77686_pmic_probe(struct platform_device *pdev)
    > +{

    > +
    > + for (i = 0; i < pdata->num_regulators; i++) {
    > + config.dev = max77686->dev;
    > + config.init_data = pdata->regulators[i].init_data;
    > + config.driver_data = max77686;
    > + config.regmap = iodev->regmap;
    > +
    > + rdev[i] = regulator_register(&regulators[i], &config);


    I'm sorry that i missed one. You have to register all regulators
    unconditionally. Mark brown commented about this to my former patch.

    'No, you should unconditionally register all regulators the device
    physically has. This is useful for debug and simplifies the code.'
    - from Mark Brown



    Thanks.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-05-23 04:21    [W:0.026 / U:59.520 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site