Messages in this thread | | | Date | Tue, 22 May 2012 12:30:31 +0200 | From | Lars-Peter Clausen <> | Subject | Re: [PATCH] gpio-charger: use cansleep version of gpio_set_value |
| |
On 05/22/2012 10:50 AM, Pritesh Raithatha wrote: > Context of gpio_charger_get_property is sleepable so we should > use gpio_set_value_cansleep instead of gpio_set_value. > > It will remove WARN_ON incase of using gpio from i2c-to-gpio > expander like pca953x. > > Signed-off-by: Pritesh Raithatha <praithatha@nvidia.com>
Looks good,
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> --- > drivers/power/gpio-charger.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c > index 8672c91..cb2aa31 100644 > --- a/drivers/power/gpio-charger.c > +++ b/drivers/power/gpio-charger.c > @@ -54,7 +54,7 @@ static int gpio_charger_get_property(struct power_supply *psy, > > switch (psp) { > case POWER_SUPPLY_PROP_ONLINE: > - val->intval = gpio_get_value(pdata->gpio); > + val->intval = gpio_get_value_cansleep(pdata->gpio); > val->intval ^= pdata->gpio_active_low; > break; > default:
| |