Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 00/15] tools: Unify perf and trace-cmd trace event format parsing v3 | Date | Mon, 21 May 2012 15:40:04 +0900 |
| |
Hi, Ingo
On Mon, 7 May 2012 10:14:24 +0200, Ingo Molnar wrote: > * Frederic Weisbecker <fweisbec@gmail.com> wrote: >> This is essentially a rebase against latest tip:perf/core updates. >> Mostly due to conflicts against the perf Makefile updates. >> >> I think we all agree that this library needs improvements but these >> should rather be done incrementally. The current perf trace event parsing >> is anyway much backward compared to that library. >> >> Default target is a static library in tools/lib/traceevent/libtraceevent.a >> >> This can be pulled from: >> >> git://github.com/fweisbec/tracing.git >> perf/parse-events-4 > > It gives me: > > /home/mingo/tip/tools/lib/traceevent/parse-filter.c: In function ‘create_arg_item’: > /home/mingo/tip/tools/lib/traceevent/parse-filter.c:343:9: warning: comparison between ‘enum filter_arg_type’ and ‘enum event_type’ [-Wenum-compare] > /home/mingo/tip/tools/lib/traceevent/parse-filter.c:339:2: warning: case value ‘8’ not in enumerated type ‘enum filter_arg_type’ [-Wswitch] > > Had this been in tools/perf/ it would use -Werror already and > you'd have fixed it, not requiring me to unpull these bits :-/ > > So can we please make a libevent.so, built sanely within > tools/perf/lib/ or such and distributed together with perf so > that the two can never get out of sync? >
So what are you gonna do with this patchset? If you merge this series, I can back-port latest changes on trace-cmd and do my further work like 'die' removal on it.
Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |